Skip to content

Open LUKS containers before mounting volumes.#26

Open
dmatetelki wants to merge 1 commit into
Sabayon:masterfrom
dmatetelki:reorder_luks_and_start_volume
Open

Open LUKS containers before mounting volumes.#26
dmatetelki wants to merge 1 commit into
Sabayon:masterfrom
dmatetelki:reorder_luks_and_start_volume

Conversation

@dmatetelki

Copy link
Copy Markdown

As described in issue:
#25

@kernelOfTruth

Copy link
Copy Markdown

@cs0rbagomba

thanks for addressing this !

BUMP

@alinefr

alinefr commented Mar 5, 2016

Copy link
Copy Markdown
Contributor

Some people may want to encrypt a single zvol instead of a pool. That's why git://anongit.gentoo.org/proj/genkernel.git tries to import a zpool before and after luks. So I did it here, trying to unlock before and after luks: alinefr/genkernel-next@489f9fe

@lxnay

lxnay commented Mar 7, 2016

Copy link
Copy Markdown
Member

We should do both and call start_volumes before and after (need to check if start_volumes is idempotent though).
This because we may discover luks partitions only after start_volumes too.

@ptMuta

ptMuta commented Oct 22, 2017

Copy link
Copy Markdown

The lack of integration of the simple fix by @alinefr forces me to use a custom build instead of the repository build... Could this be resolved after almost three years of pending solution? @mudler ?

@dmatetelki

dmatetelki commented Nov 10, 2017

Copy link
Copy Markdown
Author

@ptMuta : I have to use custom genkernel builds too because of this.

Guys, can we have some progress?

@mudler

mudler commented Nov 26, 2017

Copy link
Copy Markdown
Member

start_volumes should be harmless and idempotent, but since this issue have been sitting here for ages we should take action - Let's test, keep it on master and wait later if someone will complain and file bugs ✨

@ptMuta

ptMuta commented Nov 26, 2017 via email

Copy link
Copy Markdown

@mudler

mudler commented Nov 26, 2017

Copy link
Copy Markdown
Member

And that's why i said should

@lovesegfault

Copy link
Copy Markdown

Can this please be merged?

@dmatetelki

dmatetelki commented Jan 14, 2019

Copy link
Copy Markdown
Author

It might be fixed already with: 5a1db22

which issues the 2 lines twice:

start_volumes
zfs_start_volumes

setup_keymap

# Initialize LUKS root device except for livecd's
is_livecd || start_luks

start_volumes
zfs_start_volumes

I haven't tasted if works.

@lovesegfault

Copy link
Copy Markdown

I tried it a little while back, but with no success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants